Closed
Conversation
Collaborator
|
@rafaelgieschke thanks again. Same as the #1254 with adding tests to ensure functionality. |
c900ade to
754544b
Compare
Contributor
Author
|
Added a test. |
implausible
previously approved these changes
Nov 28, 2017
Member
|
@rafaelgieschke Any chance you can fix the conflicts? I'd like toget this into the codebase. |
754544b to
b7e8260
Compare
Contributor
Author
|
@implausible Thanks for looking at this! I've rebased the PR onto the current master. |
Contributor
|
please rebase and reopen if still relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1010 added
Blob.createFromStream()but no way to actually use the resultingWritestream.This pull request adds
Writstream#write, so you can create blobs like:It does so by declaring a fake
git_writestream_writefunction, matching thewritefunction instruct writestreamof libgit2 (https://github.com/libgit2/libgit2/blob/HEAD/include/git2/types.h#L430).