Make Tree#createUpdated usable#1254
Merged
implausible merged 3 commits intonodegit:masterfrom Jul 23, 2019
Merged
Conversation
32c5a32 to
bb4c0bd
Compare
Collaborator
|
@rafaelgieschke sorry about taking so long to look at this. This is great! Could you provide some tests to ensure functionality now and in the future please? |
Closed
Collaborator
|
Perfect, thanks! |
Contributor
Author
|
@johnhaley81 Thanks for looking at this. I added a simple test. |
|
Hey @rafaelgieschke and @johnhaley81. I was curious if this change is ready to be merged? It looks like it might have been forgotten. |
Contributor
Author
|
@stewartlord Yes, this and #1255 should be ready to be merged. |
|
This would be great! Any chance it can be rebased and get merged? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Tree#createUpdatedis not usable as newTreeUpdates cannot be constructed andcreateUpdated(repo, nupdates, updates)only accepts a singleTreeUpdateasupdates.This pull request allows to
new TreeUpdate()and turnsupdatesinto anArray<TreeUpdate>.Usage is, e.g., as follows: