Fix pipelines get stuck in a paused state by Karakatiza666 · Pull Request #5223 · feldera/feldera

Karakatiza666 · 2025-12-03T14:43:27Z

In the first commit I fixed that callbacks that are supposed to run when desired pipeline state after an action is reached, don't.
In the second commit I added an optimization to start the pipeline directly if no relations are selected in the change stream.

Fix #4822: skip the PAUSED state if we don't need to listen for any changes

#5218 should be evaluated, tested and merged some time after this PR.

Copilot

Pull request overview

This PR fixes an issue where pipelines get stuck in a paused state by ensuring callbacks run when the desired pipeline state is reached. It also optimizes pipeline startup by skipping the pause-unpause sequence when no change stream relations are selected.

Key Changes:

Initialized usePipelineAction globally to maintain waiter state across UI contexts
Added optimization to skip PAUSED state when no relations are selected in Change Stream
Refactored pipeline action handling to use a singleton pattern via getPipelineAction()

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
js-packages/web-console/src/routes/(system)/(authenticated)/+layout.svelte	Initializes `usePipelineAction` at the authenticated layout level
js-packages/web-console/src/routes/(system)/(authenticated)/(pipelines)/pipelines/[pipelineName]/+layout.svelte	Removed redundant effect that refreshed pipeline list data
js-packages/web-console/src/lib/compositions/usePipelineAction.svelte.ts	Core fix: made `postPipelineAction` a singleton and added optimization to skip pause state when no relations selected
js-packages/web-console/src/lib/compositions/pipelines/usePipelineList.svelte.ts	Added debug logging and removed unused import
js-packages/web-console/src/lib/components/pipelines/table/AvailableActions.svelte	Updated to use `getPipelineAction()` instead of `usePipelineAction()`
js-packages/web-console/src/lib/components/pipelines/list/Actions.svelte	Updated to use `getPipelineAction()` instead of `usePipelineAction()`
js-packages/web-console/src/lib/components/pipelines/editor/TabChangeStream.svelte	Added `hasSelectedRelations()` helper function to check if pipeline has selected relations
js-packages/web-console/src/lib/components/layout/pipelines/PipelineEditLayout.svelte	Updated to use `getPipelineAction()` and removed unused variables

Copilot · 2025-12-03T14:44:37Z

js-packages/web-console/src/lib/compositions/pipelines/usePipelineList.svelte.ts


 export const usePipelineList = (preloaded?: { pipelines: PipelineThumb[] }) => {
  if (preloaded && !pipelines) {
+    console.log('setting in usePipelineList:', preloaded, pipelines)


Debug logging statement should be removed before merging to production. This appears to be temporary debugging code that was left in.

Suggested change

console.log('setting in usePipelineList:', preloaded, pipelines)

Copilot · 2025-12-03T14:44:37Z

js-packages/web-console/src/lib/compositions/usePipelineAction.svelte.ts

+let postPipelineAction: (pipeline_name: string, action: PipelineAction, callbacks?: {
+    onPausedReady?: (pipelineName: string) => Promise<void>;
+}) => Promise<{
+    waitFor: () => Promise<boolean>;


The module-level postPipelineAction variable lacks documentation explaining why it needs to be a singleton and how the initialization pattern works. Consider adding a comment explaining that this is initialized once by usePipelineAction() and reused by getPipelineAction() to maintain waiter state across UI contexts.

Copilot · 2025-12-03T14:44:38Z

js-packages/web-console/src/lib/components/layout/pipelines/PipelineEditLayout.svelte

-  const pipelineAction = usePipelineAction()
-
-  const api = usePipelineManager()
+  const { updatePipelines } = useUpdatePipelineList()


The updatePipeline function was removed from destructuring but may still be needed elsewhere in the file. Verify that removing this doesn't break any functionality, as the original code imported both updatePipelines and updatePipeline.

gz · 2025-12-04T01:57:14Z

I tagged @mihaibudiu for review because he is the one that is more familiar with the language. By now I forgot everything about how typescript works.

mihaibudiu

I don't know how to test this, and there are no tests, so I can only hope that it addresses the issues enumerated.

mihaibudiu · 2025-12-04T01:58:33Z

js-packages/web-console/src/lib/components/pipelines/editor/MonitoringPanel.svelte

    untrack(() => pipelineActionCallbacks.add('', 'delete', forgetCurrentTab))
    return () => {
-      pipelineActionCallbacks.remove('', 'start_paused', forgetCurrentTab)
+      pipelineActionCallbacks.remove('', 'delete', forgetCurrentTab)


was this a bug?

mihaibudiu · 2025-12-04T02:00:46Z

js-packages/web-console/src/routes/(system)/(authenticated)/+layout.svelte

  import { useContextDrawer } from '$lib/compositions/layout/useContextDrawer.svelte'
  import { getConfig } from '$lib/services/pipelineManager'
  import { invalidateAll } from '$app/navigation'
+  import { usePipelineAction } from '$lib/compositions/usePipelineAction.svelte'


I don't know how this file works
how lovely, using parens and plus in file names.

I can quickly go through it when you have the time. It's the syntax of the SvelteKit file-based router that resolves the URL in the browser to the Svelte page

mihaibudiu · 2025-12-04T02:02:43Z

js-packages/web-console/src/lib/compositions/usePipelineAction.svelte.ts

-  return {
-    postPipelineAction: async (
+  // We initialize a global state that will be reused across all calls to `getPipelineAction`.
+  // This allows keeping the same waiters alive while switching UI context


I don't know who the waiters are or what switching UI context means, but perhaps I have missed too many reviews of this code to understand

mihaibudiu · 2025-12-04T02:03:50Z

js-packages/web-console/src/lib/compositions/usePipelineAction.svelte.ts

+            predicate: (ps) => {
+              const p = ps.find((p) => p.name === pipeline_name)
+              if (!p) {
+                throw new Error('Pipeline not found in pipelines list')


is this the right thing to do?
can the users delete the pipelines (e.g., using the sdk) while this is happening?

mihaibudiu · 2025-12-04T02:07:05Z

js-packages/web-console/src/lib/compositions/usePipelineAction.svelte.ts

+                return null
+              }
+              if (
+                (['Paused', 'AwaitingApproval'] satisfies PipelineStatus[]).findIndex(


you really like to write code that is hard to understand

mihaibudiu · 2025-12-04T02:08:09Z

js-packages/web-console/src/lib/compositions/usePipelineAction.svelte.ts

+              if (p.status === 'Stopped') {
+                return { value: false }
+              }
+              throw new Error(


so if any of these errors happens no callbacks are run. is this what you expect?

lalithsuresh · 2025-12-04T14:08:28Z

@Karakatiza666 please add tests.

…and leaving the page Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

…cted in change stream Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

…a bug Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

Karakatiza666 requested review from Copilot and gz December 3, 2025 14:43

Copilot AI reviewed Dec 3, 2025

View reviewed changes

gz requested review from mihaibudiu and removed request for gz December 4, 2025 01:56

mihaibudiu reviewed Dec 4, 2025

View reviewed changes

Karakatiza666 added 4 commits December 5, 2025 10:48

[WebConsole] Fix pipelines left in a paused state when starting them …

a8310ec

…and leaving the page Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

[WebConsole] Avoid pausing pipeline on start if no relations are sele…

6762a15

…cted in change stream Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

[WebConsole] Remove an unused multi-tenancy optimization that causes …

cd6131f

…a bug Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

Minor fixes

2f9fc42

Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

Karakatiza666 enabled auto-merge December 5, 2025 11:08

Karakatiza666 force-pushed the fix-ui-5 branch from b34e712 to 2f9fc42 Compare December 5, 2025 11:12

mihaibudiu approved these changes Dec 5, 2025

View reviewed changes

Karakatiza666 added this pull request to the merge queue Dec 5, 2025

Merged via the queue into main with commit 0db08da Dec 5, 2025
1 check passed

Karakatiza666 deleted the fix-ui-5 branch December 5, 2025 18:05

Conversation

Karakatiza666 commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

gz commented Dec 4, 2025

Uh oh!

mihaibudiu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lalithsuresh commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants