Refactor pipeline state transition detection to run callbacks on#5218
Draft
Karakatiza666 wants to merge 6 commits intomainfrom
Draft
Refactor pipeline state transition detection to run callbacks on#5218Karakatiza666 wants to merge 6 commits intomainfrom
Karakatiza666 wants to merge 6 commits intomainfrom
Conversation
Contributor
|
Can #4822 fix be a separate PR? |
Contributor
Author
|
Ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the registered callbacks on pipeline actions were only executed when these actions were triggered from web-console. For example, you couldn't follow the change stream if a pipeline was started through the API.
Now the occurred pipeline actions are derived from each pipeline's status transitions, received when polling
/v0/pipelines.Aside from the functional changes, the new implementation has lower coupling to adjacent code than the previous one.
Fix #4822: skip the PAUSED state if we don't need to listen for any changes