Comments kinda trivial but whatever.
Router contract has according methods for exact input only so there is no need to rework make_trade_output() as it wraps exact output methods.
If we need these calls for swap then usage gonna be like
make_trade(token0, token1, qty, ... fee_on_transfer=True)
If we don't then just omit fee_on_transfer param.
Also, please note that univ3 doesn't and won't support this kind of tokens.

Do the tests pass for you locally? (CI is not working right for PRs... #88)

I like your suggestions about method selection but can't commit them as they are marked "outdated" dunno why. Tests are OK.

Nice! Just one more thing: run black on the files to apply correct formatting.

After that I'll merge 🙂

Nice! Just one more thing: run black on the files to apply correct formatting.

After that I'll merge 🙂

Bruh I swear I didn't got ya🤷‍♀️

Nice! Just one more thing: run black on the files to apply correct formatting.

After that I'll merge 🙂

+++
Seems OK

Hello,
First thanks for the great repo you built.

I tried to buy reflection tokens with make_trade(token0, token1, qty, ... fee_on_transfer=True) but I still get an error:
"reason : transaction failed"

Do you have an idea why?

Thanks

still get an error:
"reason : transaction failed"
Do you have an idea why?

Well, this PR hasn't been merged yet.

LGTM, merging.

Thanks for your contributions @liquid-8!

Hello,
First thanks for the great repo you built.

I tried to buy reflection tokens with make_trade(token0, token1, qty, ... fee_on_transfer=True) but I still get an error:
"reason : transaction failed"

Do you have an idea why?

Thanks

@debaenenicolas if problem still persists please create thread in Discussions.