fix: (useCopyToClipboard): copyToClipboard should return promise#313
Open
kendrickw wants to merge 1 commit intouidotdev:mainfrom
Open
fix: (useCopyToClipboard): copyToClipboard should return promise#313kendrickw wants to merge 1 commit intouidotdev:mainfrom
kendrickw wants to merge 1 commit intouidotdev:mainfrom
Conversation
|
Please merge this. Currently this other npm lib has a working version: |
|
up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312
The copyToClipboard function is not returning a promise currently. The intention (at least according to the function signature) is to fulfill the promise when the text is copied:
usehooks/index.d.ts
Lines 126 to 129 in 90fbbb4
This PR will change the code to return a promise. So the promise can fulfill when the text is copied successfully.