Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 72.92% 72.90% -0.02%
==========================================
Files 26 26
Lines 1839 1838 -1
Branches 347 347
==========================================
- Hits 1341 1340 -1
Misses 395 395
Partials 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update to use the new libtmux v0.50.0 API. The attach_session() method was deprecated in favor of attach().
Replace deprecated window-specific option methods with the new unified options API: - show_window_option() -> show_option() - show_window_options() -> show_options() - set_window_option() -> set_option() - g=True parameter -> global_=True The new API returns Python-native types (bool, int) instead of strings, so removed unnecessary int() cast for pane-base-index.
- Update mock paths from attach_session to attach - Replace deprecated show_window_option/set_window_option with show_option/set_option - Update g=True to global_=True parameter - Fix assertions to expect bool instead of str for on/off options (libtmux now returns True/False instead of "on"/"off")
Document the internal API changes made to support libtmux v0.50.0's unified options API and note the return type changes for options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
py(deps) libtmux 0.49.0 -> 0.50.0
See also: https://libtmux.git-pull.com/history.html#libtmux-0-50-0-2025-11-30
Internal updates to use libtmux's new unified options API:
Session.attach_session()→Session.attach()Window.show_window_option()→Window.show_option()Window.show_window_options()→Window.show_options()Window.set_window_option()→Window.set_option()g=Trueparameter →global_=TrueNote: Options now return Python-native types (
True/Falseinstead of"on"/"off",intinstead of numeric strings).