fix: correct typos and minor code quality issues#42827
Open
yogeshwaran-c wants to merge 1 commit intosupabase:masterfrom
Open
fix: correct typos and minor code quality issues#42827yogeshwaran-c wants to merge 1 commit intosupabase:masterfrom
yogeshwaran-c wants to merge 1 commit intosupabase:masterfrom
Conversation
- Fix STYLING_CONGIF -> STYLING_CONFIG typo in LW handler functions - Fix geneartedOGImage -> generatedOGImage typo in lwx-ticket-og handler - Fix console.log -> console.warn and "Cant find" -> "Can't find" in docs generator legacy.ts - Add missing alt attribute to img element in AuthProvidersForm FormField
|
@yogeshwaran-c is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks for contributing to Supabase! ❤️ Our team will review your PR. A few tips for a smoother review process:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
WalkthroughThis pull request addresses multiple typo fixes and minor improvements across the codebase. Changes include correcting console logging behavior, enhancing form accessibility with an alt attribute, fixing misspelled styling configuration constants in OG image handlers, and correcting a variable name in the ticket OG handler. Changes
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Code quality / cleanup
What is the current behavior?
Several typos and minor code quality issues exist across the codebase:
STYLING_CONGIF(should beSTYLING_CONFIG) typo in Launch Week handler functions (lwx-ticket, lwx-og, lw11-og)geneartedOGImage(should begeneratedOGImage) typo in lwx-ticket-og handlerconsole.logused for warning-level messages in docs generatorlegacy.ts, and "Cant find" missing apostrophealtattribute on<img>element inAuthProvidersForm/FormField.tsxWhat is the new behavior?
STYLING_CONGIF->STYLING_CONFIGacross all 3 LW handler filesgeneartedOGImage->generatedOGImagein lwx-ticket-og handlerconsole.log->console.warnwith "Can't find" grammar fix in legacy.tsalt={option.label}to the img element in FormField for accessibilityAdditional context
All changes are safe renames within file scope (no cross-file references). The
STYLING_CONGIFtypo appears in variable declaration and all its usages within each file, so the rename is self-contained. The accessibility fix adds a descriptive alt attribute using the already-availableoption.labelvalue.Summary by CodeRabbit