Skip to content

improvement(jsm): destructured outputs for jsm, jira, and added 1password integration#3174

Merged
waleedlatif1 merged 9 commits intostagingfrom
improvement/jsm
Feb 10, 2026
Merged

improvement(jsm): destructured outputs for jsm, jira, and added 1password integration#3174
waleedlatif1 merged 9 commits intostagingfrom
improvement/jsm

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Feb 9, 2026

Summary

  • destructured outputs for jsm, jira, and added 1password integration

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Feb 10, 2026 1:58am

Request Review

@waleedlatif1 waleedlatif1 force-pushed the improvement/jsm branch 4 times, most recently from befd4b2 to 7f568f1 Compare February 9, 2026 23:48
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 9, 2026

Greptile Overview

Greptile Summary

This PR adds 1Password tool support (API routes, tool wrappers, and block registration) and refactors Jira/Jira Service Management tools to return more structured/destructured outputs. It also updates the docs site to include the new 1Password integration and adjusts icon mappings/registry entries so the new tool shows up in the UI/tooling registry.

Confidence Score: 2/5

  • This PR should not be merged until the 1Password secret-handling and credential-visibility issues are confirmed and fixed.
  • Large surface-area change (new credentialed integration + many API/tool wrappers) with no automated tests added. The main concerns are (1) potential exposure of resolved secrets via API responses/logs and (2) credential fields using the wrong visibility class, which can lead to unsafe handling and UX/security regressions.
  • apps/sim/app/api/tools/onepassword/, apps/sim/blocks/blocks/onepassword.ts, apps/sim/tools/onepassword/

Important Files Changed

Filename Overview
apps/docs/components/icons.tsx Updates docs icon exports/mappings to include new tool icons.
apps/docs/components/ui/icon-mapping.ts Extends docs icon mapping for additional tools (incl. 1Password).
apps/sim/app/api/tools/onepassword/resolve-secret/route.ts Implements resolve-secret API route, but currently returns plaintext secrets in the JSON response (must be fixed before merge).
apps/sim/tools/jira/types.ts Refactors Jira tool response types to destructured objects and cursor pagination; introduces breaking output shape changes that require coordinated updates.
apps/sim/blocks/blocks/onepassword.ts Adds 1Password block configuration/fields for connection modes and credentials (visibility appears to be user-only in tool params).
apps/sim/app/api/tools/onepassword/utils.ts Adds shared 1Password API utilities; verify no helpers accidentally log/return sensitive values.
apps/sim/tools/onepassword/resolve_secret.ts Tool wrapper surfaces output.secret from API response; combined with the route behavior this leads to secret persistence/exposure.

Sequence Diagram

sequenceDiagram
  participant UI as Sim UI/Runner
  participant Tool as Tool wrapper (apps/sim/tools/onepassword/resolve_secret)
  participant API as Next.js API route (/api/tools/onepassword/resolve-secret)
  participant OP as 1Password SDK/API

  UI->>Tool: Execute resolve_secret(secretReference)
  Tool->>API: POST secretReference + credentials
  API->>OP: resolve(secretReference)
  OP-->>API: plaintext secret
  API-->>Tool: JSON { secret, reference }
  Tool-->>UI: output.secret (persisted/displayed)
Loading

greptile-apps[bot]
greptile-apps bot reviewed Feb 9, 2026
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 9, 2026

Additional Comments (1)

apps/sim/tools/jira/types.ts
Breaking output shape change
JiraSearchIssuesResponse/bulk retrieve output types remove fields like startAt/maxResults and change fields like status/assignee/priority from strings to objects, plus introduce cursor pagination (nextPageToken, isLast). Any existing consumers expecting the old shape will break at runtime/compile time. Please either keep backward-compatible fields or bump/coordinate all internal callers to the new schema in the same PR.

@waleedlatif1 waleedlatif1 merged commit b3dbb44 into staging Feb 10, 2026
11 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/jsm branch February 10, 2026 03:28
@waleedlatif1 waleedlatif1 mentioned this pull request Feb 10, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1