Skip to content

Fixes Incompatability with newer Elasticsearch Systems#3411

Closed
J12934 wants to merge 1 commit intosecureCodeBox:mainfrom
J12934:bugfix/elasticsearch-response-fix
Closed

Fixes Incompatability with newer Elasticsearch Systems#3411
J12934 wants to merge 1 commit intosecureCodeBox:mainfrom
J12934:bugfix/elasticsearch-response-fix

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Dec 9, 2025

Complete reimpementation of #3391 from scratch with proper signoff.
Wasn't able to merge the original PR because of the missing signoff.

Thank you @conleth for the intial PR and for raising the ticket :)
Closes #3385

Fixes secureCodeBox#3385

Co-authored-by: Conleth Kennedy <conlethkennedy@gmail.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 self-assigned this Dec 9, 2025
@J12934 J12934 added the bug Bugs label Dec 9, 2025
@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit 77a4789
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/693822ce035d8e00085f0245

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
31.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@J12934 J12934 moved this from Triage to To Review in secureCodeBox Dec 9, 2025
@conleth
Copy link
Contributor

conleth commented Dec 9, 2025

Complete reimpementation of #3391 from scratch with proper signoff. Wasn't able to merge the original PR because of the missing signoff.

Thank you @conleth for the intial PR and for raising the ticket :) Closes #3385

Thank you, sorry I was busy this weekend was meaning to get to this. Can I still be included in the contributors? This was my first open source contribution.

@J12934
Copy link
Member Author

J12934 commented Dec 9, 2025

Sure, we can of course still go with your PR :)
Would prefer that too. DCO check needs to pass though.

You can fix the DCO stuff for the existing commits (see: https://github.com/secureCodeBox/secureCodeBox/pull/3391/checks?check_run_id=56373070867)

To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~3 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin bugfix/persistence-elastic-es8-response

@conleth
Copy link
Contributor

conleth commented Dec 9, 2025

Sure, we can of course still go with your PR :) Would prefer that too. DCO check needs to pass though.

You can fix the DCO stuff for the existing commits (see: https://github.com/secureCodeBox/secureCodeBox/pull/3391/checks?check_run_id=56373070867)

To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~3 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin bugfix/persistence-elastic-es8-response

Awesome I'll do that when I finish work!

@J12934 J12934 closed this Dec 9, 2025
@github-project-automation github-project-automation bot moved this from To Review to Done in secureCodeBox Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Elasticsearch 8.x compatibility issue: persistence-elastic hook fails with TypeError on bulk indexing

2 participants