Skip to content

Fix missing sslyze findings with sslyze 6.x#3351

Merged
Weltraumschaf merged 8 commits intosecureCodeBox:mainfrom
J12934:bugfix/fix-sslyze-findings-with-sslyze-6.x
Nov 6, 2025
Merged

Fix missing sslyze findings with sslyze 6.x#3351
Weltraumschaf merged 8 commits intosecureCodeBox:mainfrom
J12934:bugfix/fix-sslyze-findings-with-sslyze-6.x

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented Nov 5, 2025

Description

Noticed that with sslyze 6.2.0 some of the findings are not properly generated anymore due to changes in the sslyze format.
I have added a quick script to regen all test files for sslyze which can be easily reproduced.

Then updated the parser to properly generate the findings again.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
The badssl tls 1.0 also finally had the support for tls 1.1 dropped which is also removed here :)

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 self-assigned this Nov 5, 2025
@J12934 J12934 added the bug Bugs label Nov 5, 2025
@J12934 J12934 moved this from Triage to To Review in secureCodeBox Nov 5, 2025
@netlify
Copy link

netlify bot commented Nov 5, 2025

Deploy Preview for docs-securecodebox ready!

Name Link
🔨 Latest commit 050d5ce
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/690c4d9298a873000804cdd8
😎 Deploy Preview https://deploy-preview-3351--docs-securecodebox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
…sted via `--certinfo_ca_file`

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@github-project-automation github-project-automation bot moved this from To Review to Reviewer Approved in secureCodeBox Nov 5, 2025
@Weltraumschaf
Copy link
Member

@J12934 License check failed.

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@Weltraumschaf Weltraumschaf merged commit 3544f1e into secureCodeBox:main Nov 6, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in secureCodeBox Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants