Add proposed ADR to use CEL in CascadingRules#3328
Merged
Weltraumschaf merged 3 commits intosecureCodeBox:mainfrom Oct 22, 2025
Merged
Add proposed ADR to use CEL in CascadingRules#3328Weltraumschaf merged 3 commits intosecureCodeBox:mainfrom
Weltraumschaf merged 3 commits intosecureCodeBox:mainfrom
Conversation
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Most of the text and structure here is generated based on the following prompt, then manually reviewed, just in case anybody wants to save time reading boilerplate :D ```prompt Please have a look at the current syntax for CascadingRules in the following files: documentation/docs/how-tos/scanning-networks.md documentation/docs/api/crds/cascading-rule.md Please write a ADR in the documentation/docs/architecture/09_architecture_decisions directory with a sugegsted move to switch out the custom `matches` object syntax of the CascadingRule with the Common Expression Language (CEL). The goal here would be make the CascadingRules more dynamic by allowing a wide range of expressions without us having to model the matcher syntax for everything ourself. describe the pros and cons of that approach try to follow the structure of existing ADRs in this repo ``` Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| To ensure backward compatibility and smooth migration: | ||
|
|
||
| 1. **Dual Support Period**: Support both the legacy `matches.anyOf` syntax and the new `matches.expression` syntax simultaneously for at least two major versions. |
Member
There was a problem hiding this comment.
What happens if accidentally both is configured? Precedence of CEL + warning?
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
|
Weltraumschaf
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
See ADR :)
Checklist