Skip to content

Avoid confusion in cascading scans between http on port 443#3271

Merged
J12934 merged 2 commits intosecureCodeBox:mainfrom
Reet00:nmap-parser
Oct 8, 2025
Merged

Avoid confusion in cascading scans between http on port 443#3271
J12934 merged 2 commits intosecureCodeBox:mainfrom
Reet00:nmap-parser

Conversation

@Reet00
Copy link
Contributor

@Reet00 Reet00 commented Sep 11, 2025

When running a nmap service scan (-sV) https is marked as ssl/http instead of https, which has resulted into problems with our cascadingscan hook.
Proposed solution: Set tunnel attribute by default to string "none" which can be matched in the cascadingrules

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Reet00 Reet00 self-assigned this Sep 11, 2025
@Reet00 Reet00 added the scanner Implement or update a security scanner label Sep 11, 2025
@netlify
Copy link

netlify bot commented Sep 11, 2025

Deploy Preview for docs-securecodebox canceled.

Name Link
🔨 Latest commit ed6cdb7
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/68dce1a0d1405f0008754fa2

@Reet00 Reet00 requested a review from J12934 September 11, 2025 10:54
@Reet00
Copy link
Contributor Author

Reet00 commented Sep 11, 2025

Also opened an issue with nmap to verify that this is intentional and not a bug.
nmap/nmap#3188

@Reet00 Reet00 moved this from Triage to To Review in secureCodeBox Sep 11, 2025
servicescans use http/ssl notation which results into confusion
with the matching of cascadingscans
So tunnel is given a default value so the https can be matched with
tunnel

Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
Signed-off-by: Samreet Singh <samreet.singh@iteratec.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.2% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-project-automation github-project-automation bot moved this from To Review to Reviewer Approved in secureCodeBox Oct 8, 2025
@J12934 J12934 merged commit dc46f44 into secureCodeBox:main Oct 8, 2025
47 of 48 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in secureCodeBox Oct 8, 2025
@Weltraumschaf Weltraumschaf added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hacktoberfest https://hacktoberfest.digitalocean.com/ scanner Implement or update a security scanner

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants