Improve container security by ensuring that the executed code can't be modified by the container user#3035
Merged
Reet00 merged 1 commit intosecureCodeBox:mainfrom May 23, 2025
Conversation
Fixes Sonar docker:S6504 warning Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Reet00
reviewed
May 23, 2025
Contributor
Reet00
left a comment
There was a problem hiding this comment.
Would it make sense to add a comment in secureCodeBox/.templates/new-scanner/scanner/Dockerfile so we don't encounter this issue for a new scanner again?
Member
Author
The new scanner template is already changed so not sure why we would also need a comment in there? Would hope that if if it is used the generated code would already be be corrected. 😊 |
Reet00
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes Sonar docker:S6504 warning for all our image where it applies.
https://sonarcloud.io/organizations/iosecurecodebox/rules?open=docker%3AS6504&rule_key=docker%3AS6504
Not suuuuper relevant for most of our images as the are run with a read only filesystem, but doesn't hurt to follow best practices.
Excluded the doggo one as theres a PR open to remove it :)
Checklist