Fix Issue with nested Kubernetes Native Objects not being properly configurable in the Kubernetes AutoDiscovery Config#2982
Merged
J12934 merged 3 commits intosecureCodeBox:mainfrom Apr 22, 2025
Conversation
✅ Deploy Preview for docs-securecodebox canceled.
|
Contributor
Author
|
Resolves #2724 |
…overy Viper was misparsing the inline fields of corev1.Volume objects, causing issues with our YAML configuration files for auto-discovery. To resolve this, we are switching to sigs.k8s.io/yaml for unmarshalling. Replace time.Duration with metav1.Duration in autodiscovery_config.go structs to accommodate the way sigs.k8s.io/yaml handles string values representing time in YAML files. Signed-off-by: Boris Shek <boris.shek@iteratec.com>
…_loader.go in auto-discovery Update auto-discovery unit test snapshot. Signed-off-by: Boris Shek <boris.shek@iteratec.com>
Correct a minor typographical error in service_scan_controller.go regarding the RequeueAfter value. Signed-off-by: Boris Shek <boris.shek@iteratec.com>
0e9d4fd to
aaed2c5
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viper was misparsing the inline fields of corev1.Volume objects, causing issues with our YAML configuration files for auto-discovery. To resolve this, we are switching to sigs.k8s.io/yaml for unmarshalling. Replace time.Duration with metav1.Duration in autodiscovery_config.go structs to accommodate the way sigs.k8s.io/yaml handles string values representing time in YAML files.
Replace time.Duration with metav1.Duration in autodiscovery_config.go structs to accommodate the way sigs.k8s.io/yaml handles string values representing time in YAML files.
Description
Checklist