Skip to content

show-names - Fix spacing in conversation events#8970

Open
mschoettle wants to merge 8 commits intorefined-github:mainfrom
mschoettle:mschoettle-patch-1
Open

show-names - Fix spacing in conversation events#8970
mschoettle wants to merge 8 commits intorefined-github:mainfrom
mschoettle:mschoettle-patch-1

Conversation

@mschoettle
Copy link

@mschoettle mschoettle commented Feb 11, 2026

There is margin missing on the inserted name element for timeline items like "User added some commits" or "User force-pushed".

It is only missing on non-comments and those without .markdown-title (since they have their own CSS rule to change it to a flex container with gap).

Test URLs

Screenshot

Before

image
image

After

image
image

@mschoettle mschoettle changed the title Add margin for names in comment context show-names: Add margin for names in comment context Feb 11, 2026
@github-actions github-actions bot changed the title show-names: Add margin for names in comment context show-names: Add margin for names in comment context Feb 11, 2026
@mschoettle mschoettle changed the title show-names: Add margin for names in comment context show-names: Add margin for names outside comment context Feb 11, 2026
@mschoettle mschoettle marked this pull request as ready for review February 11, 2026 17:23
@fregante fregante changed the title show-names: Add margin for names outside comment context show-names - Fix spacing in conversation events Feb 12, 2026
@fregante fregante added the bug label Feb 12, 2026
else if

fixes

try to make issue rename event selector more redable

lint
@fregante
Copy link
Member

fregante commented Feb 15, 2026

If would be good to include a comment with the test URL in each block, plus ideally a description of what to look for. Long conditions like these can become hard to parse and test later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants