Conversation
fregante
commented
Nov 11, 2025
| } | ||
|
|
||
| linkifyIssues(getRepo()!, paragraph); | ||
| }; |
Comment on lines
+186
to
+187
| 'import/consistent-type-specifier-style': 'off', | ||
| 'import-x/consistent-type-specifier-style': 'off', |
Member
Author
There was a problem hiding this comment.
I don't know what's up with antfu's eslint config and at this point I'm afraid to ask.
|
Please add labels to this PR |
| return [...readmeContent.matchAll(featureRegex)] | ||
| .map(match => extractDataFromMatch(match)) | ||
| .sort((firstFeature, secondFeature) => firstFeature.id.localeCompare(secondFeature.id)); | ||
| .toSorted((firstFeature, secondFeature) => firstFeature.id.localeCompare(secondFeature.id)); |
Member
There was a problem hiding this comment.
why use toSorted on a newly created array?
Member
There was a problem hiding this comment.
almost all reverse -> toReversed and sort -> toSorted changes seem to be meaningless
Member
There was a problem hiding this comment.
you are creating not two, but three arrays here 😭
Member
Author
There was a problem hiding this comment.
Such is life sindresorhus/eslint-plugin-unicorn#2735 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buncha autofixes. Needs review