comments-time-machine-links - Fix date parameter disappearing #8754
Merged
fregante merged 6 commits intorefined-github:mainfrom Nov 11, 2025
Merged
comments-time-machine-links - Fix date parameter disappearing #8754fregante merged 6 commits intorefined-github:mainfrom
comments-time-machine-links - Fix date parameter disappearing #8754fregante merged 6 commits intorefined-github:mainfrom
Conversation
SunsetTechuila
commented
Nov 9, 2025
| const comment = relativeTime.closest(`:is(${commentSelector})`)!; | ||
| addInlineLinks(comment, relativeTime.attributes.datetime.value); | ||
| }, | ||
| `:is(${commentSelector}) a[href^="${location.origin}"]:not(.${linkifiedURLClass})`, |
Member
Author
There was a problem hiding this comment.
this should be safe to replace with .markdown-body a[href^="${location.origin}"]:not(.${linkifiedURLClass})
comments-time-machine-links.tsx - Fix date parameter disappearing
comments-time-machine-links.tsx - Fix date parameter disappearing comments-time-machine-links - Fix date parameter disappearing
SunsetTechuila
commented
Nov 9, 2025
Comment on lines
128
to
144
| @@ -138,8 +143,8 @@ async function addDropdownLinkReact({delegateTarget: delegate}: DelegateEvent): | |||
| $('[class^="prc-ActionList-ItemLabel"]', menuItem).textContent = 'View repo at this time'; | |||
| $('[class^="prc-ActionList-LeadingVisual"]', menuItem).replaceChildren(<HistoryIcon />); | |||
Member
Author
There was a problem hiding this comment.
should I use createDropdownItem?
It looks fine when wrapped with an element that provides inline margin
fregante
approved these changes
Nov 10, 2025
Member
fregante
left a comment
There was a problem hiding this comment.
Looks mostly right 🙏 will review again tomorrow
Co-authored-by: fregante <me@fregante.com>
696a944 to
a44de93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #8712 (comment)
fixes the issue of the date parameter not reappearing after a comment was edited
addresses some review comments
Test URLs
#8698
Screenshot