Allow users to get rid of scroll warning when rendering a flatlist in…#3901
Open
ali139713 wants to merge 1 commit intoreact-native-elements:nextfrom
Open
Allow users to get rid of scroll warning when rendering a flatlist in…#3901ali139713 wants to merge 1 commit intoreact-native-elements:nextfrom
ali139713 wants to merge 1 commit intoreact-native-elements:nextfrom
Conversation
…side bottomsheet.
1 task
vegtelenseg
reviewed
May 5, 2024
| <ScrollView {...scrollViewProps}>{children}</ScrollView> | ||
| <View> | ||
| {disableScroll ? ( | ||
| <View>{children}</View> |
There was a problem hiding this comment.
I think this view, just like ScrollView should take some props.
Author
|
Yes, But I think this is already keeping it simple.
Would you like to add to this change ?
…On Sun, May 5, 2024 at 9:04 AM Siya ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/base/src/BottomSheet/BottomSheet.tsx
<#3901 (comment)>
:
> @@ -69,8 +70,12 @@ export const BottomSheet: RneFunctionComponent<BottomSheetProps> = ({
pointerEvents="box-none"
{...rest}
>
- <View>
- <ScrollView {...scrollViewProps}>{children}</ScrollView>
+ <View>
+ {disableScroll ? (
+ <View>{children}</View>
I think this view, just like ScrollView should take some props.
—
Reply to this email directly, view it on GitHub
<#3901 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMYJ3LNZ3H2HK24CJIWR4F3ZAWVWBAVCNFSM6AAAAABHCUZ2EOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZZGU3TQMBSHE>
.
You are receiving this because you authored the thread.Message ID:
<react-native-elements/react-native-elements/pull/3901/review/2039578029@
github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…side bottomsheet.
Motivation
Fixes # (issue)
Type of change
How Has This Been Tested?
exampleappChecklist
yarn docs-build-apiAdditional context