Build system improvements pack - addressing comments to PR and some issues.#546
Merged
den-run-ai merged 7 commits intopythonnet:masterfrom Nov 7, 2017
Merged
Conversation
…ore-2.0-x86 installation step removed.
|
@dmitriyse, thanks! @vmuriart, @tonyroberts, @davidanthoff, @tiran and @rickardraysearch, please review this. |
Contributor
Author
|
Please do not review this branch, until I commit and test all part of the solution. |
Contributor
|
@dmitriyse please use [WIP] in your PR title when it is Work In Progress. |
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 77.16% 77.14% -0.03%
==========================================
Files 65 65
Lines 5610 5617 +7
Branches 888 888
==========================================
+ Hits 4329 4333 +4
- Misses 993 996 +3
Partials 288 288
Continue to review full report at Codecov.
|
…m interop*.cs file inside IDE.
Contributor
Author
|
Thank you for the tip. |
d3c72ad to
f1229bd
Compare
Contributor
Author
|
PR is ready !
|
Contributor
Author
|
It's so good to be a member of the core team, now I can kill broken builds without waiting. :) |
filmor
approved these changes
Sep 22, 2017
4 tasks
den-run-ai
approved these changes
Oct 8, 2017
Contributor
|
@dmitriyse i think this is good to merge! if @vmuriart can take a quick look at code coverage failures, that's great, but that is not blocking this PR merge. |
2b633a2 to
0273abf
Compare
dmitriyse
pushed a commit
that referenced
this pull request
Nov 16, 2017
dmitriyse
added a commit
that referenced
this pull request
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes issues specified in reviews for PR #518 and PR #519 and fix for the issue #539
Does this close any currently open issues?
#539
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG