@vmuriart @denfromufa @tonyroberts Please review.

@filmor can you add tests compatible with both python 2 and 3 that use cPickle:

try:
   import cPickle as pickle
except:
   import pickle

@denfromufa Done. Please check :)

So is this a "feature" or "bug fix"? If latter, then let's merge this for
v2.2.0! If not, can we wait until I release binaries for v2.2.0?

Have you ran the embedding tests to make sure that exceptions do not break
on the other side of the bridge?

On Wed, Nov 9, 2016 at 4:22 AM, Benedikt Reinartz notifications@github.com
wrote:

@denfromufa https://github.com/denfromufa Done. Please check :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#286 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5YJv7_fge093W5Qyqjpt9lSXkpmnks5q8Z72gaJpZM4KsPc9
.

I haven't run the embedded tests, I'll check how to do that.

This is definitely a bug fix, and a pretty critical one from my point of view (as said, this was killing my worker processes in production).

Ok, please let me know if you have any luck running embedding tests and
then we can merge this for v2.2.0.

BTW, why do you pickle exceptions - really seems a wild idea to me?

On Wed, Nov 9, 2016 at 9:20 AM, Benedikt Reinartz notifications@github.com
wrote:

I haven't run the embedded tests, I'll check how to do that.

This is definitely a bug fix, and a pretty critical one from my point of
view (as said, this was killing my worker processes in production).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#286 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5eVtKokXm3Jlt06_TqaF3qQ8Ei7xks5q8eS6gaJpZM4KsPc9
.

The tests work against Python 3.5 (though they have various issues, I'll prepare a PR).

I pass the exceptions back from a multiprocessing worker to show them to the user, and during that they are automatically pickled.