Match generic and private methods upon runtime reload#1637
Merged
lostmsu merged 1 commit intopythonnet:masterfrom Dec 20, 2021
Merged
Match generic and private methods upon runtime reload#1637lostmsu merged 1 commit intopythonnet:masterfrom
lostmsu merged 1 commit intopythonnet:masterfrom
Conversation
filmor
approved these changes
Dec 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The old method matching code never worked for generic methods because their parameter types did not have assembly qualified names.
The new method explicitly checks generic parameters.
It also allows reloading of private methods, which can be exposed to Python via reflection or delegate binding.
Any other comments?
This is part of work to remove all shutdown modes (only Reload will remain), that ensures, that internal methods are always successfully reloaded.
Checklist
Check all those that are applicable and complete.
CHANGELOG