Make .NET objects that have __call__ method callable from Python#1589
Merged
filmor merged 1 commit intopythonnet:masterfrom Oct 14, 2021
Merged
Make .NET objects that have __call__ method callable from Python#1589filmor merged 1 commit intopythonnet:masterfrom
__call__ method callable from Python#1589filmor merged 1 commit intopythonnet:masterfrom
Conversation
d0f8cdc to
00cca0f
Compare
Implemented by adding tp_call to ClassBase, that uses reflection to find __call__ methods in .NET fixes pythonnet#890 this is an amalgamation of d46878c, 5bb1007, and 960457f from https://github.com/losttech/pythonnet
filmor
approved these changes
Oct 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Implemented by adding
tp_calltoClassBase, that uses reflection to find__call__methods in .NET, and falls back to invoking__call__method from Python base classes.Does this close any currently open issues?
Implements #890
Any other comments?
This is an amalgamation of d46878c, 5bb1007, and 960457f from https://github.com/losttech/pythonnet
Checklist
Check all those that are applicable and complete.
CHANGELOG