ClassManager illegally decrefed ClassObject's refcount on shutdown#1563
Merged
lostmsu merged 1 commit intopythonnet:masterfrom Sep 22, 2021
Merged
ClassManager illegally decrefed ClassObject's refcount on shutdown#1563lostmsu merged 1 commit intopythonnet:masterfrom
ClassManager illegally decrefed ClassObject's refcount on shutdown#1563lostmsu merged 1 commit intopythonnet:masterfrom
Conversation
be2eefa to
9616a6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this close any currently open issues?
#1561
Any other comments?
Long term we should switch
ManagedTypeand other classes, that hold long-lived references to Python objects to usePyObject. This would make any code, that uses them refcount-balanced automatically.See #1562
Checklist