Names of .NET types changed to better support generic types#1509
Merged
lostmsu merged 1 commit intopythonnet:masterfrom Aug 7, 2021
Merged
Names of .NET types changed to better support generic types#1509lostmsu merged 1 commit intopythonnet:masterfrom
lostmsu merged 1 commit intopythonnet:masterfrom
Conversation
filmor
reviewed
Aug 5, 2021
src/runtime/typemanager.cs
Outdated
| static string CleanupFullName(string fullTypeName) | ||
| { | ||
| // Cleanup the type name to get rid of funny nested type names. | ||
| string name = "CLR." + fullTypeName; |
src/runtime/typemanager.cs
Outdated
| target.Append(nonGenericName); | ||
|
|
||
| var arguments = clrType.GetGenericArguments(); | ||
| target.Append('<'); |
Member
There was a problem hiding this comment.
Could it make sense to use the "Python syntax" instead, i.e. square brackets?
0ae4bad to
15cf488
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Previously, Python.NET would produce confusing type names in certain scenarios (generic and/or nesting types).
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG