Fixed __cause__ on overload bind failure and array conversion#1442
Merged
lostmsu merged 1 commit intopythonnet:masterfrom Apr 14, 2021
Merged
Fixed __cause__ on overload bind failure and array conversion#1442lostmsu merged 1 commit intopythonnet:masterfrom
__cause__ on overload bind failure and array conversion#1442lostmsu merged 1 commit intopythonnet:masterfrom
Conversation
Member
|
As there are probably a few more places like this, shouldn't we add a convenience |
Member
Author
|
@filmor I do not think it is justified at this moment: with just these two places I don't get any more related assertion failures of that nature with debug builds of Python throughout out test suite. |
| } | ||
|
|
||
| value.Append(": "); | ||
| Runtime.PyErr_Fetch(out var errType, out var errVal, out var errTrace); |
Member
Author
There was a problem hiding this comment.
It might let us reenable the test case, but the issue that caused it will still be there.
BadSingleton
approved these changes
Apr 13, 2021
Contributor
BadSingleton
left a comment
There was a problem hiding this comment.
LGTM. However this is something easy to miss. It'd be great if we had pythonnet in debug (without Py_Debug) be able to detect known cases.
also: added debug check
650ac77 to
a95945b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Calls to
PyObject_StrandPyObject_Reprshould not be made with error set, as they may clear it. When using debug build of Python, this causes an assertion at runtime, preventing use of Python.NET.Does this close any currently open issues?
Partial fix for #1412