Adds test cases for member changes during a domain reload by BadSingleton · Pull Request #1275 · pythonnet/pythonnet

BadSingleton · 2020-11-09T20:30:46Z

The tests are marked as expected failures for now.

What does this implement/fix? Explain your changes.

This adds a test harness/framework for renaming/removing members during domain reload. Actual fixes for these tests will com in other pull request(s).

Does this close any currently open issues?

This will help start addressing #1250

Any other comments?

This supersedes, in part, #1269

Checklist

Check all those that are applicable and complete.

Make sure to include one or more tests for your change
If an enhancement PR, please create docs and at best an example
Add yourself to AUTHORS
Updated the CHANGELOG

The tests are marked as expected failures for now.

dnfadmin · 2020-11-09T20:31:00Z

All CLA requirements met.

codecov-io · 2020-11-09T21:36:13Z

Codecov Report

Merging #1275 (3adc559) into master (182faed) will decrease coverage by 3.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1275      +/-   ##
==========================================
- Coverage   87.97%   84.53%   -3.44%     
==========================================
  Files           1        1              
  Lines         291      291              
==========================================
- Hits          256      246      -10     
- Misses         35       45      +10

Flag	Coverage Δ
setup_linux	`59.45% <ø> (-5.85%)`	⬇️
setup_windows	`74.22% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup.py	`84.53% <0.00%> (-3.44%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182faed...3adc559. Read the comment docs.

…t-cases

Even though it tests nothing.

lostmsu

What's the status of the time spent running these tests? Are they only enabled for supported configurations?

lostmsu · 2020-11-26T06:12:35Z

src/domain_tests/Python.DomainReloadTests.15.csproj

+  <PropertyGroup Condition="$(Configuration.Contains('Debug')) AND '$(TargetFramework)'=='netstandard2.0'">
+    <DebugSymbols>true</DebugSymbols>
+    <Optimize>false</Optimize>
+    <DebugType>full</DebugType>
+  </PropertyGroup>
+  <PropertyGroup Condition="$(Configuration.Contains('Release')) AND '$(TargetFramework)'=='netstandard2.0'">
+    <DebugSymbols>true</DebugSymbols>
+    <Optimize>true</Optimize>
+    <DebugType>portable</DebugType>
+  </PropertyGroup>


A lot of stuff in this file seems like unnecessary clutter. Can you clean it up?

It's mostly a copy from another project file. I'll see what I can remove

lostmsu · 2020-11-26T06:14:09Z

pythonnet.sln

+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.DebugWinPY3|x64.Build.0 = DebugWinPY3|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.DebugWinPY3|x86.ActiveCfg = DebugWinPY3|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.DebugWinPY3|x86.Build.0 = DebugWinPY3|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMono|x64.ActiveCfg = ReleaseMono|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMono|x86.ActiveCfg = ReleaseMono|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMonoPY3|x64.ActiveCfg = ReleaseMonoPY3|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseMonoPY3|x86.ActiveCfg = ReleaseMonoPY3|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x64.ActiveCfg = ReleaseWin|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x64.Build.0 = ReleaseWin|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x86.ActiveCfg = ReleaseWin|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWin|x86.Build.0 = ReleaseWin|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x64.ActiveCfg = ReleaseWinPY3|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x64.Build.0 = ReleaseWinPY3|x64
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x86.ActiveCfg = ReleaseWinPY3|x86
+		{7539EBD5-7A15-4513-BCB0-1D9BEF112BC2}.ReleaseWinPY3|x86.Build.0 = ReleaseWinPY3|x86


Does the new project really need all these configurations? It might just need Debug and Release. Solution configurations do not have to map 1:1 to project configurations.

Probably not. I think it does require a x86 variant lest the xplat build doesn't run. I'll see what I can remove.

BadSingleton · 2020-11-26T14:59:27Z

What's the status of the time spent running these tests? Are they only enabled for supported configurations?

Good question. Each case takes ~2.2 seconds on my machine. Because they run through pytest, I haven't found a way to have them not run in netstandard builds (where the runner code is ifdef'd out). The solution might be to move the test harness to a nunit test

lostmsu · 2020-11-28T22:04:05Z

Has this been completely superseded by #1287 ?

BadSingleton · 2020-11-29T01:40:42Z

Has this been completely superseded by #1287 ?

We can consider it has. The original plan was to have the tests merged in before the fixes, but the fixes requires the tests..

Adds test cases for member changes during a domain reload

fc7da1d

The tests are marked as expected failures for now.

!fixup add the project to the solution files

72fafdd

BadSingleton added 2 commits November 18, 2020 14:28

Add more test cases

20861b2

Merge remote-tracking branch 'upstream/master' into domain-reload-tes…

2253ef3

…t-cases

BadSingleton mentioned this pull request Nov 19, 2020

Domain reload test cases fixes #1287

Merged

4 tasks

BadSingleton added 2 commits November 19, 2020 15:42

Make the tests run as netcoreapp

635edac

Even though it tests nothing.

Remove stray colon

0ee931e

lostmsu requested changes Nov 26, 2020

View reviewed changes

BadSingleton added 2 commits November 26, 2020 14:34

Clean up the project and solution files

5f061bc

Merge branch 'master' into domain-reload-test-cases

3adc559

BadSingleton closed this Nov 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds test cases for member changes during a domain reload#1275

Adds test cases for member changes during a domain reload#1275
BadSingleton wants to merge 8 commits intopythonnet:masterfrom
Unity-Technologies:domain-reload-test-cases

BadSingleton commented Nov 9, 2020 •

edited

Loading

Uh oh!

dnfadmin commented Nov 9, 2020 •

edited

Loading

Uh oh!

codecov-io commented Nov 9, 2020 •

edited

Loading

Uh oh!

lostmsu left a comment

Uh oh!

lostmsu Nov 26, 2020

Uh oh!

BadSingleton Nov 26, 2020

Uh oh!

lostmsu Nov 26, 2020

Uh oh!

BadSingleton Nov 26, 2020

Uh oh!

BadSingleton commented Nov 26, 2020

Uh oh!

lostmsu commented Nov 28, 2020

Uh oh!

BadSingleton commented Nov 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

BadSingleton commented Nov 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

Any other comments?

Checklist

Uh oh!

dnfadmin commented Nov 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Nov 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lostmsu left a comment

Choose a reason for hiding this comment

Uh oh!

lostmsu Nov 26, 2020

Choose a reason for hiding this comment

Uh oh!

BadSingleton Nov 26, 2020

Choose a reason for hiding this comment

Uh oh!

lostmsu Nov 26, 2020

Choose a reason for hiding this comment

Uh oh!

BadSingleton Nov 26, 2020

Choose a reason for hiding this comment

Uh oh!

BadSingleton commented Nov 26, 2020

Uh oh!

lostmsu commented Nov 28, 2020

Uh oh!

BadSingleton commented Nov 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BadSingleton commented Nov 9, 2020 •

edited

Loading

dnfadmin commented Nov 9, 2020 •

edited

Loading

codecov-io commented Nov 9, 2020 •

edited

Loading