This repository was archived by the owner on Sep 22, 2020. It is now read-only.
Reintroduce python2 support#26
Closed
mafrosis wants to merge 1 commit intopython-thumbnails:masterfrom
mafrosis:python2
Closed
Reintroduce python2 support#26mafrosis wants to merge 1 commit intopython-thumbnails:masterfrom mafrosis:python2
mafrosis wants to merge 1 commit intopython-thumbnails:masterfrom
mafrosis:python2
Conversation
Author
|
As mentioned in #24 |
Member
|
This breaks stuff, we will at least need to get the pillow builds green before we can think about merging this. |
Author
|
I can't see what's changed in there that could break those Pillow tests. It's unable to open a test image file in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking at adding better Flask support, and an S3 backend. Unfortunately, my project uses python2! Can you review this pull request can see that everything looks okay?
A simple
git revert ee52b65d1bba847a964652c6e9aa40460595e654got me most of the way there. I had conflicts in: