long SMS decode and unbind handle#75
Conversation
ywshzh
commented
Dec 19, 2018
- long SMS decode, deal UDHI indicator in esm_class(01xxxxxx)
- add unbind handle when unbind recv
1. long SMS decode, deal UDHI indicator in esm_class(01xxxxxx) 2. add unbind handle when unbind recv
|
I closed the last pr I submitted and downloaded the latest version to manually sync my code. But this automatic test tool still reports an error, I am not very clear about the meaning of this error. |
|
This is my first time to submit pr on github, not very clear about the operation process, and my english is not very good, I am sorry! |
eigenein
left a comment
There was a problem hiding this comment.
This is fine @ywshzh, thanks for contribution!
As regarding the error, you need to add 'udhi_field' there:
python-smpplib/smpplib/command.py
Line 393 in a82e6be
The error message says that the parameter is not allowed because it's not in that list.
smpplib/client.py
Outdated
| return self.sequence_generator.next_sequence() | ||
|
|
||
| def connect(self): | ||
| def connect(self, timeout=5): |
There was a problem hiding this comment.
Could you use the existing timeout parameter from __init__?
There was a problem hiding this comment.
Thanks for correcting, I am sorry to have missed this place when manually merging the code, I have fixed the submission. Parameter timeout I also added it to the member variable
add udhi_field in Param
add timeout to members
keep a newline in the end of the files, and use the const (SMPP_GSMFEAT_UDHI) below
use the const SMPP_GSMFEAT_UDHI
|
Please, rebase |
1. long SMS decode, deal UDHI indicator in esm_class(01xxxxxx) 2. add unbind handle when unbind recv
1. long SMS decode, deal UDHI indicator in esm_class(01xxxxxx)
2. add unbind handle when unbind recv
you want i combine multiple commits into one?is it okay now? |
|
Ok, I'll try to provide instructions
no, you need to |
|
I needed that feature and even though the PR hasn't been merged, I was able to use your code @ywshzh and I wanted to thank you very much. It works like a charm. I skipped a migraine here. |