Improve PEP-compliance and testing#56
Merged
eigenein merged 1 commit intopython-smpplib:masterfrom Oct 11, 2018
eigenein:master
Merged
Improve PEP-compliance and testing#56eigenein merged 1 commit intopython-smpplib:masterfrom eigenein:master
eigenein merged 1 commit intopython-smpplib:masterfrom
eigenein:master
Conversation
Collaborator
Author
|
@podshumok Could you please take a quick look if it's okay for you? |
code-of-kpp
reviewed
Oct 11, 2018
smpplib/client.py
Outdated
| if sequence_generator is None: | ||
| sequence_generator = SimpleSequenceGenerator() | ||
| self.sequence_generator = sequence_generator | ||
| self.sequence_generator = sequence_generator or SimpleSequenceGenerator() |
Member
There was a problem hiding this comment.
I think is None version is better here as people may want to override __bool__ for things like sequence generators
Collaborator
Author
There was a problem hiding this comment.
Yeah, makes sense. I'll change it back.
Member
|
Some strings are too long for my screen (I have vision problems and hence I use PEP8 recommended 79 columns). Apart from that it looks good. |
Collaborator
Author
|
Got it, will reformat those lines. |
* Add `tox.ini`, support `2.6`, `2.7`, `3.4`, `3.5`, `3.6` and `3.7` * Drop Python `3.2` and `3.3` support * Improve PEP8-compliance in a few places * Bump version to `1.0.2` and mark it as stable * Add classifiers to `setup.py` * Improve `.gitignore` with standard templates for popular environments * Remove some dead code in comments
Collaborator
Author
|
Oki, addressed the comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox.ini, support2.6,2.7,3.4,3.5,3.6and3.73.2and3.3support1.0.2and mark it as stablesetup.py.gitignorewith standard templates for popular environments