Add support for enabled check_hostname in SSL connections#259
Open
glut23 wants to merge 1 commit intopython-smpplib:masterfrom
Open
Add support for enabled check_hostname in SSL connections#259glut23 wants to merge 1 commit intopython-smpplib:masterfrom
glut23 wants to merge 1 commit intopython-smpplib:masterfrom
Conversation
sakaal
approved these changes
Mar 25, 2025
code-of-kpp
approved these changes
Mar 25, 2025
Member
code-of-kpp
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I think there is some risk of breaking things for people, who, for example, connect to servers by IP, but I'd accept it: it's better if people would have to face the problem directly than to have a potential silent security issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on an SMPP connection over TLS, my colleague @sakaal and I, noticed that enabling
check_hostnameoption did not work. This was due to the inability to passserver_hostnamefor the SSL/TLS handshake.This pull request adds support to ensure hostname verification can be properly enforced in SSL/TLS connections.