Skip to content

increment sequence of commands as spec (fixes #214)#215

Merged
eigenein merged 3 commits intopython-smpplib:masterfrom
emnoor:increment_sequence_as_spec
Mar 9, 2023
Merged

increment sequence of commands as spec (fixes #214)#215
eigenein merged 3 commits intopython-smpplib:masterfrom
emnoor:increment_sequence_as_spec

Conversation

@emnoor
Copy link
Contributor

@emnoor emnoor commented Mar 5, 2023

fixes #214

made need_sequence=True for the following commands:

  • BindTransmitter
  • BindReceiver
  • BindTransceiver
  • Unbind
  • DeliverySM
  • EnquireLink

emnoor added 3 commits March 5, 2023 14:03
made need_sequence=True for the following commands:
- BindTransmitter
- BindReceiver
- BindTransceiver
- Unbind
- DeliverySM
- EnquireLink
@eigenein eigenein marked this pull request as ready for review March 7, 2023 21:38
Copy link
Collaborator

@eigenein eigenein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emnoor, looks good to me! Can this be merged?

@eigenein eigenein added the bug label Mar 7, 2023
@eigenein eigenein self-assigned this Mar 7, 2023
@emnoor
Copy link
Contributor Author

emnoor commented Mar 8, 2023

Hello @eigenein, we have tested the patch on our production and it is working fine. It can be merged.

@eigenein eigenein merged commit 4ddadc7 into python-smpplib:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequence number is not incremented according to spec for some commands

2 participants