Add ThreadSafeClient implementation#203
Open
PaulWasTaken wants to merge 3 commits intopython-smpplib:masterfrom
Open
Add ThreadSafeClient implementation#203PaulWasTaken wants to merge 3 commits intopython-smpplib:masterfrom
PaulWasTaken wants to merge 3 commits intopython-smpplib:masterfrom
Conversation
097d6f3 to
8faa88f
Compare
PaulWasTaken
commented
Jul 11, 2022
m4rtinpf
reviewed
Dec 3, 2022
m4rtinpf
left a comment
There was a problem hiding this comment.
Awesome idea!
Built something with this library a while back and had some issues with it being thread-unsafe.
| def send_pdu(self, pdu, send_later=False) -> bool: | ||
| if send_later: | ||
| self._send_queue.append(pdu) | ||
| self._send_sock.send(b'\x00') |
There was a problem hiding this comment.
Why are we sending a 00? Is it a no-op? If so, why are we sending it?
Author
There was a problem hiding this comment.
It is some sort of notification frame. We put it into the send socket to wake up our read socket
3600d48 to
455c19d
Compare
Author
|
@eigenein FYI |
PaulWasTaken
commented
Apr 26, 2023
|
|
||
| if not rlist: | ||
| if self._should_prolong_session(): | ||
| if not auto_send_enquire_link: |
Author
There was a problem hiding this comment.
TODO: check auto_send_enquire_link before self._should_prolong_session() call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I based it on #187.
Hope nobody minds)