Skip to content

Refactored Client.send_pdu()#197

Merged
code-of-kpp merged 1 commit intopython-smpplib:masterfrom
emnoor:sock-send-refactor
Apr 15, 2022
Merged

Refactored Client.send_pdu()#197
code-of-kpp merged 1 commit intopython-smpplib:masterfrom
emnoor:sock-send-refactor

Conversation

@emnoor
Copy link
Contributor

@emnoor emnoor commented Apr 15, 2022

use socket.sendall instead of socket.send in a loop

Fixes #196 (1)

use socket.sendall instead of socket.send in a loop
@code-of-kpp code-of-kpp merged commit df39439 into python-smpplib:master Apr 15, 2022
@emnoor emnoor deleted the sock-send-refactor branch April 15, 2022 18:30
Copy link
Collaborator

@eigenein eigenein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emnoor, this is so much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor socket read/write

3 participants