Handle errors on PDU payload retrieval#170
Merged
eigenein merged 1 commit intopython-smpplib:masterfrom Oct 19, 2021
Merged
Conversation
Contributor
Author
|
For reference, the while loop was only introduced recently: #82 |
Contributor
|
I think line 259 is meant to say if not raw_pdu_part:Also since we're repeating the exact same pattern as above, it might be a good idea to factorize it into its own function ? |
Collaborator
|
Thanks @stefanruijsenaars! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perform the same checks that we do on other calls to
socket.recv()/socket.send(), lest we ever end up in an infinite loop wheneverrecv()returns a 0 length value.