Make subaddress TLV's binary strings, rather than plain strings.#130
Open
pd5rm wants to merge 2 commits intopython-smpplib:masterfrom
pd5rm:master
Open
Make subaddress TLV's binary strings, rather than plain strings.#130pd5rm wants to merge 2 commits intopython-smpplib:masterfrom pd5rm:master
pd5rm wants to merge 2 commits intopython-smpplib:masterfrom
pd5rm:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having some issues sending source and dest subaddress (> 128) code error.
According to specs, source and dest should be octet strings, not plain strings.