feat: add support for deployment approval endpoint#2254
Merged
Conversation
nejch
reviewed
Aug 24, 2022
nejch
reviewed
Aug 24, 2022
Member
nejch
left a comment
There was a problem hiding this comment.
Thanks LGTM! Just a quick question mostly about upstream API weirdness.
Add support for the deployment approval endpoint[1] [1] https://docs.gitlab.com/ee/api/deployments.html#approve-or-reject-a-blocked-deployment Closes: #2253
9f9e25b to
9c9eeb9
Compare
Codecov Report
@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
+ Coverage 87.23% 95.41% +8.18%
==========================================
Files 81 81
Lines 5375 5390 +15
==========================================
+ Hits 4689 5143 +454
+ Misses 686 247 -439
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the deployment approval endpoint[1]
[1] https://docs.gitlab.com/ee/api/deployments.html#approve-or-reject-a-blocked-deployment
Closes: #2253