@JohnVillalovos this uses a private interface, see my comment at #2219 (comment).

@JohnVillalovos this uses a private interface, see my comment at #2219 (comment).

It is documented in the official docs, which to me means it is supposed to be used.

https://docs.python.org/3/library/urllib.parse.html

As is the case with all named tuples, the subclass has a few additional methods and attributes that are particularly useful. One such method is _replace(). The _replace() method will return a new ParseResult object replacing specified fields with new values.

Codecov Report

Merging #2221 (6d1b62d) into main (d263f57) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2221   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          81       81           
  Lines        5368     5368           
=======================================
  Hits         5124     5124           
  Misses        244      244           

Flags with carried forward coverage won't be shown. Click here to find out more.

My theory is that because the urllib.parse.ParseResult is a namedtuple they preface functions with underscores. I don't think it is required but maybe it is "best practice" 🤷‍♂️

The namedtuple documentation sort-of mentions that: https://docs.python.org/3/library/collections.html#collections.namedtuple

In addition to the methods inherited from tuples, named tuples support three additional methods and two attributes. To prevent conflicts with field names, the method and attribute names start with an underscore.

Ok, I will begrudgingly merge this 🐱