Conversation
8c17afa to
2a209c3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
+ Coverage 92.01% 92.10% +0.08%
==========================================
Files 76 76
Lines 4799 4801 +2
==========================================
+ Hits 4416 4422 +6
+ Misses 383 379 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Jan 8, 2022
Member
nejch
left a comment
There was a problem hiding this comment.
Thanks again John! Just a few questions.
ca85f93 to
94dd1e0
Compare
Member
|
As discussed let's call this a |
We were using `str.replace()` calls to take care of URL encoding issues. Switch them to use our `utils._url_encode()` function which itself uses `urllib.parse.quote()` Closes: #1356
94dd1e0 to
3d49e5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
str.replace()calls to take care of URL encodingissues.
Switch them to use our
utils._url_encode()function which itself usesurllib.parse.quote()Closes: #1356