Codecov Report

Merging #1606 (6944bc7) into master (227607c) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
+ Coverage   91.59%   91.85%   +0.25%     
==========================================
  Files          74       74              
  Lines        4272     4295      +23     
==========================================
+ Hits         3913     3945      +32     
+ Misses        359      350       -9     

Flags with carried forward coverage won't be shown. Click here to find out more.

@nejch this PR should be ready for review/merge

Hi @Pro, thanks for this PR. Just a few notes on this:

• could you squash your commits to one fix commit? See how commit messages affect our changelog here: https://github.com/python-gitlab/python-gitlab/blob/master/CONTRIBUTING.rst#releases
• It'd be great if you could add some unit tests for this. We've had a lot of issues around url-encoding, and we want to prevent sometimes double encoding things.
• eventually we should find a central place to fix this encoding problem. See Get rid of all custom URL encoding #1356 for more details.

I squashed all the commits. Currently I cannot invest more time into writing tests, maybe in a few weeks when there is more time, sorry.

@Pro this might need a rebase now as we've switched to f-strings.

Hi @Pro! This was part of a much larger URL-encoding issue and this PR provides a specific solution in update().

I believe we have now solved the underlying issue in a more general way that solves it for all endpoints and ensures a string is only ever URL-encoded once: #1819.

So I'll close this PR as I think the issue is fixed and we have tests for this now. But thanks again for your contribution, it showed us how widespread the URL-encoding problem was. Feel free to report any more issues or PRs if you find anything else :)