fix(objects): rename confusing to_project_id argument#1599
Merged
JohnVillalovos merged 1 commit intomasterfrom Sep 11, 2021
Merged
fix(objects): rename confusing to_project_id argument#1599JohnVillalovos merged 1 commit intomasterfrom
to_project_id argument#1599JohnVillalovos merged 1 commit intomasterfrom
Conversation
BREAKING CHANGE: rename confusing `to_project_id` argument in transfer_project to `project_id` (`--project-id` in CLI). This is used for the source project, not for the target namespace.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1599 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 74 74
Lines 4263 4263
=======================================
Hits 3904 3904
Misses 359 359
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
approved these changes
Sep 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rename confusing
to_project_idargument in transfer_projectto
project_id(--project-idin CLI). This is used for the source project,not for the target namespace.
Closes #1529.