feat: add support for lists of integers to ListAttribute#1415
Merged
nejch merged 1 commit intopython-gitlab:masterfrom Apr 26, 2021
JohnVillalovos:jlvillal/list_attribute_int
Merged
feat: add support for lists of integers to ListAttribute#1415nejch merged 1 commit intopython-gitlab:masterfrom JohnVillalovos:jlvillal/list_attribute_int
nejch merged 1 commit intopython-gitlab:masterfrom
JohnVillalovos:jlvillal/list_attribute_int
Conversation
Previously ListAttribute only support lists of integers. Now be more flexible and support lists of items which can be coerced into strings, for example integers. This will help us fix issue #1407 by using ListAttribute for the 'iids' field.
Codecov Report
@@ Coverage Diff @@
## master #1415 +/- ##
=======================================
Coverage 80.18% 80.18%
=======================================
Files 73 73
Lines 4063 4063
=======================================
Hits 3258 3258
Misses 805 805
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nejch
approved these changes
Apr 26, 2021
Member
nejch
left a comment
There was a problem hiding this comment.
I think it's a good idea to merge this first :) later when it comes to individual endpoints it might be good to add int. tests for those to see how gitlab behaves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ListAttribute only support lists of integers. Now be more
flexible and support lists of items which can be coerced into strings,
for example integers.
This will help us fix issue #1407 by using ListAttribute for the
'iids' field.