refactor(tests): split functional tests#1205
Merged
max-wittig merged 2 commits intomasterfrom Oct 9, 2020
Merged
Conversation
nejch
commented
Oct 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 11 11
Lines 2826 2826
=======================================
Hits 2192 2192
Misses 634 634 Continue to review full report at Codecov.
|
max-wittig
requested changes
Oct 8, 2020
Member
max-wittig
left a comment
There was a problem hiding this comment.
Awesome work. Just a few suggestions!
524183f to
65ce026
Compare
Member
Author
Thanks for the quick review Max! I pushed 65ce026 to address the suggestions :) |
Member
|
Very very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glorious copy/paste time! This just splits functional tests in the hope we get more control over weird timing failures.
No attempts yet to add fixture factories which would be very useful here :P But for now, this provides a
wait_for_sidekiqhelper that should hopefully make it easier to solve if there are still issues.This will be a pain to review, I wish GitHub/GitLab had code move detection like Review Board :( But the file sizes should be more reasonable now:
Closes #1113, #1105, #1065, hopefully closes #1033.
Also I realized when doing this that anything to do with group creation/deletion is really slow so maybe it'll help with #1194.