bpo-44754: Spell out 's.pop() or s.pop(i)' in stdtypes.rst table#27398
Merged
ambv merged 1 commit intopython:mainfrom Jul 28, 2021
Merged
bpo-44754: Spell out 's.pop() or s.pop(i)' in stdtypes.rst table#27398ambv merged 1 commit intopython:mainfrom
ambv merged 1 commit intopython:mainfrom
Conversation
Contributor
|
Thanks @sweeneyde for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 2ff5bb4) Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
|
GH-27412 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 28, 2021
(cherry picked from commit 2ff5bb4) Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
|
GH-27413 is a backport of this pull request to the 3.9 branch. |
|
GH-27414 is a backport of this pull request to the 3.8 branch. |
ambv
pushed a commit
that referenced
this pull request
Jul 28, 2021
ambv
pushed a commit
that referenced
this pull request
Jul 28, 2021
ambv
pushed a commit
that referenced
this pull request
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using [square brackets] to declare optional formal parameters in argument lists is okay in general, but the rest of this table shows prototypical usage, not formal declaration. There is already a clarifying footnote about the default case.
https://bugs.python.org/issue44754