bpo-37493: use _PyObject_CallNoArg in more places#14575
bpo-37493: use _PyObject_CallNoArg in more places#14575methane merged 1 commit intopython:masterfrom
Conversation
skrah
left a comment
There was a problem hiding this comment.
I'm a bit surprised --- we discussed on bpo to use fewer places, but you add more.
So please take out the decimal changes. I'll add new functions as I see fit.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
I'm not sure what you mean. The only thing that we discussed (on bpo-37483 which relates to a different PR) is that maybe we should not use private functions in So please let me know whether the changes to |
|
The PR title mentions So perhaps there are too many new functions. I'll decide later if to use any of these, so yes, please take them out. |
Even if it's not speed sensitive, I see no reason to prefer |
|
|
|
Thanks for making the requested changes! @skrah: please review the changes made to this pull request. |
CC @vstinner @methane
https://bugs.python.org/issue37493