Propagate SyntheticEvent to 'this' in preventDefault and stopPropagation functions#48
Merged
mjrussell merged 1 commit intopurescript-react:mainfrom Jan 11, 2023
miuirussia:main
Merged
Propagate SyntheticEvent to 'this' in preventDefault and stopPropagation functions#48mjrussell merged 1 commit intopurescript-react:mainfrom miuirussia:main
mjrussell merged 1 commit intopurescript-react:mainfrom
miuirussia:main
Conversation
Member
|
Was able to reproduce the issue here https://github.com/ptrfrncsmrph/purescript-react-events-bug and confirmed the fix locally |
Member
|
Thanks for this @miuirussia and @ptrfrncsmrph for additional testing. Just approved to run it through ci and should be able to get this in shortly |
Member
|
Release in v6.1.0. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since purescript has ability to compile with different backends (as https://github.com/aristanetworks/purescript-backend-optimizer), functions can be compiled as arrow functions, which results error in react. So we must explicitly specify, that the preventDefault and stopPropagation functions require a SyntheticEvent in 'this'.
See: https://github.com/facebook/react/blob/afe6521e134178920f0523ede4c715942d8f0564/packages/react-dom-bindings/src/events/SyntheticEvent.js#L89