Setting view, viewInv and cameraPos uniforms to shaders by default #5504#5506
Open
Dawars wants to merge 1 commit intoprocessing:masterfrom
Open
Setting view, viewInv and cameraPos uniforms to shaders by default #5504#5506Dawars wants to merge 1 commit intoprocessing:masterfrom
Dawars wants to merge 1 commit intoprocessing:masterfrom
Conversation
Author
|
Is there someone who can review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the issue #5504
The uniform names being set are the following:
view and viewMatrix
viewInv and viewInvMatrix
cameraPos and camera
Are they good?
How can I add these to the docs at https://processing.org:8443/tutorials/pshader/