Fix add_vline and add_hline with datetime axes#5508
Open
mosh3eb wants to merge 1 commit intoplotly:mainfrom
Open
Fix add_vline and add_hline with datetime axes#5508mosh3eb wants to merge 1 commit intoplotly:mainfrom
mosh3eb wants to merge 1 commit intoplotly:mainfrom
Conversation
When using add_vline with annotation_text on datetime axes, plotly was crashing with a TypeError because the _mean() helper function tried to sum date strings. Since vlines have x0==x1 and hlines have y0==y1, we can just return the first value when sum() fails on non-numeric data. This fixes the issue while maintaining full backward compatibility. Fixes plotly#3065
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using add_vline with annotation_text on datetime axes, plotly was crashing with a TypeError because the _mean() helper function tried to sum date strings.
Since vlines have x0==x1 and hlines have y0==y1, we can just return the first value when sum() fails on non-numeric data. This fixes the issue while maintaining full backward compatibility.
Fixes #3065
Code PR
plotly.graph_objects, my modifications concern the code generator and not the generated files.