Conversation
Contributor
|
Thanks @mskacelik, will have a look asap. I think the color/theme issue is probably related to the fact that the React components in PatternFly Java live in the shadow DOM rather than in the 'normal' DOM as in PatternFly React. Thus the CSS variables are unknown. I need to check how this can be fixed. |
Contributor
|
Regarding the theming/colors there's a CSS import missing in import "@patternfly/patternfly/patternfly-charts.css";With this in place the theming works. |
Contributor
Author
can confirm that did the trick :) Also rebased the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Few notes:
Donutchart can also have color scale.i.e.:
jbang code.java . && npm run watchfor the code snippet to be updated, iirc this was not needed in my component implementations.