fix: add omitempty to optional nullable fields#2221
Open
mromaszewicz wants to merge 1 commit intooapi-codegen:mainfrom
Open
fix: add omitempty to optional nullable fields#2221mromaszewicz wants to merge 1 commit intooapi-codegen:mainfrom
mromaszewicz wants to merge 1 commit intooapi-codegen:mainfrom
Conversation
Fixes oapi-codegen#2091 The `omitempty` JSON tag was not being added to optional nullable fields. The condition `!p.Nullable && shouldOmitEmpty` explicitly prevented any nullable field from receiving `omitempty`, even when the field was optional (not required). This contradicted the documented behavior. The fix removes the `!p.Nullable` guard so nullable fields follow the same `omitempty` rules as non-nullable fields. The special-case exception for the `nullable-type` output option is no longer needed since the logic is now uniform. Note: `x-go-type-skip-optional-pointer: true` on a nullable field suppresses the pointer (generating `string` instead of `*string`) but still correctly receives `omitempty` when the field is optional. Whether skip-optional-pointer should be allowed to suppress the pointer on nullable fields is a separate concern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2091
The
omitemptyJSON tag was not being added to optional nullable fields. The condition!p.Nullable && shouldOmitEmptyexplicitly prevented any nullable field from receivingomitempty, even when the field was optional (not required). This contradicted the documented behavior.The fix removes the
!p.Nullableguard so nullable fields follow the sameomitemptyrules as non-nullable fields. The special-case exception for thenullable-typeoutput option is no longer needed since the logic is now uniform.Note:
x-go-type-skip-optional-pointer: trueon a nullable field suppresses the pointer (generatingstringinstead of*string) but still correctly receivesomitemptywhen the field is optional. Whether skip-optional-pointer should be allowed to suppress the pointer on nullable fields is a separate concern.